Declare Logs Beta #311
Merged
Declare Logs Beta #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
feature/tigran/declare-logs-beta
branch
from
4907363 to
dfa2560
Compare
|
@pmm-sumo surprisingly you are not an Otel member and I cannot add you to reviewers. Please file a request to become a member :-) |
kumoroku
approved these changes
Jun 3, 2021
djaglowski
approved these changes
Jun 4, 2021
kumoroku
approved these changes
Jun 4, 2021
|
@open-telemetry/specs-logs-approvers please review. |
|
The spec now declares OTLP log Beta, so this should just mirror that decision, please approve. |
pmm-sumo
approved these changes
Jun 8, 2021
zenmoto
approved these changes
Jun 8, 2021
bogdandrutu
approved these changes
Jun 8, 2021
The Log SIG discussed and made a decision to declare Log data model and Log part of OTLP Beta. (See SIG meeting notes here https://docs.google.com/document/d/1cX5fWXyWqVVzYHSFUymYUfWxUK5hT97gc23w595LmdM/edit#heading=h.28y76as82bvu)
tigrannajaryan
force-pushed
the
feature/tigran/declare-logs-beta
branch
from
dfa2560 to
eb19661
Compare
carlosalberto
approved these changes
Jun 8, 2021
SergeyKanzhelev
approved these changes
Jun 8, 2021
jmacd
pushed a commit
that referenced
this pull request
Jun 22, 2021
… readability (#312) * moved deprecated messages to the bottom of metrics.proto to help with readability (especially for newbies!) * Declare Logs Beta (#311) The Log SIG discussed and made a decision to declare Log data model and Log part of OTLP Beta. (See SIG meeting notes here https://docs.google.com/document/d/1cX5fWXyWqVVzYHSFUymYUfWxUK5hT97gc23w595LmdM/edit#heading=h.28y76as82bvu) * incorporated feedback from PR review Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Log SIG discussed and made a decision to declare Log data model and Log part of OTLP Beta.
(See SIG meeting notes here https://docs.google.com/document/d/1cX5fWXyWqVVzYHSFUymYUfWxUK5hT97gc23w595LmdM/edit#heading=h.28y76as82bvu)