Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent definition of counts and values #117

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Consistent definition of counts and values #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d4ffdd
Consistent definition of counts and values
bogdandrutu Mar 5, 2020
3f1a29d
Use uint64 instead of fixed size integers.
bogdandrutu Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ message HistogramValue {
// count is the number of values in the population. Must be non-negative. This value
// must be equal to the sum of the "count" fields in buckets if a histogram is
// provided.
int64 count = 3;
uint64 count = 3;

// sum of the values in the population. If count is zero then this field
// must be zero. This value must be equal to the sum of the "sum" fields in buckets if
Expand All @@ -311,7 +311,7 @@ message HistogramValue {
message Bucket {
// The number of values in each bucket of the histogram, as described by
// bucket_options.
int64 count = 1;
uint64 count = 1;

// Exemplars are example points that may be used to annotate aggregated
// Histogram values. They are metadata that gives information about a
Expand Down Expand Up @@ -366,7 +366,7 @@ message SummaryValue {

// The total number of recorded values since start_time. Optional since
// some systems don't expose this.
fixed64 count = 3;
uint64 count = 3;

// The total sum of recorded values since start_time. Optional since some
// systems don't expose this. If count is zero then this field must be zero.
Expand Down