Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider generalizing profile attributes optimization to other signals #546

Open
jack-berg opened this issue Apr 18, 2024 · 0 comments
Open

Consider generalizing profile attributes optimization to other signals #546

jack-berg opened this issue Apr 18, 2024 · 0 comments
Labels
spec:profiles

Comments

@jack-berg
Copy link
Member 

          I don't disagree with this optimization, but its interesting that we choose to use it here and not elsewhere in the protocol. Wouldn't other signals, especially metrics, benefit from having a shared pool of attributes with points which reference those by index?

Originally posted by @jack-berg in #534 (comment)
@jack-berg jack-berg mentioned this issue Apr 18, 2024
Merged
VinozzZ pushed a commit to honeycombio/opentelemetry-proto that referenced this issue Jun 18, 2024
@bogdandrutu @tigrannajaryan
Move specifications into sub-directories per signal (open-telemetry#546)
02d0878 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@bogdandrutu @VinozzZ
Move specifications into sub-directories per signal (open-telemetry#546)
04e06ed 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@bogdandrutu @VinozzZ
Move specifications into sub-directories per signal (open-telemetry#546)
01a45f0 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@bogdandrutu @VinozzZ
Move specifications into sub-directories per signal (open-telemetry#546)
c465f0e 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
VinozzZ pushed a commit to VinozzZ/opentelemetry-proto that referenced this issue Jun 21, 2024
@bogdandrutu @VinozzZ
Move specifications into sub-directories per signal (open-telemetry#546)
c097cb3 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec:profiles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tigrannajaryan @jack-berg