-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot distinguish Histogram's Sum field between 0 vs not assigned. #314
Comments
FYI: @jsuereth @bogdandrutu @jmacd |
It seems we need to deprecate the use of this field, and move to a newer Sum field where we can redefine the context. This may include...
|
That flag is no longer required in version |
@jsuereth @jmacd this is now an issue for sum in the exponential histogram correct? https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L466 |
* Add field presence flag to proto build. * Fix #314 - Cannot distinguish between sum being 0 and undefined. * remove gogo from Makefile Co-authored-by: Josh Suereth <joshuasuereth@google.com>
proto3 does not support a has_*() method. Thus, code cannot detect the difference between a field that is not assigned vs a field that has a default value (i.e. 0).
Current spec for Histogram's Sum field has a note to not assign the field in some condition. This condition not detectable by code (i.e. Sum is assigned to zero).
The text was updated successfully, but these errors were encountered: