Skip to content

Commit

Permalink
Consistent definition of counts and values (#117)
Browse files Browse the repository at this point in the history
* Consistent definition of counts and values

Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>

* Use uint64 instead of fixed size integers.
  • Loading branch information
bogdandrutu authored Mar 6, 2020
1 parent c20698d commit 17257b5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ message HistogramValue {
// count is the number of values in the population. Must be non-negative. This value
// must be equal to the sum of the "count" fields in buckets if a histogram is
// provided.
int64 count = 3;
uint64 count = 3;

// sum of the values in the population. If count is zero then this field
// must be zero. This value must be equal to the sum of the "sum" fields in buckets if
Expand All @@ -311,7 +311,7 @@ message HistogramValue {
message Bucket {
// The number of values in each bucket of the histogram, as described by
// bucket_options.
int64 count = 1;
uint64 count = 1;

// Exemplars are example points that may be used to annotate aggregated
// Histogram values. They are metadata that gives information about a
Expand Down Expand Up @@ -366,7 +366,7 @@ message SummaryValue {

// The total number of recorded values since start_time. Optional since
// some systems don't expose this.
fixed64 count = 3;
uint64 count = 3;

// The total sum of recorded values since start_time. Optional since some
// systems don't expose this. If count is zero then this field must be zero.
Expand Down

0 comments on commit 17257b5

Please sign in to comment.