Apply feedback

open-telemetry · Mar 14, 2020 · 13c8eba · 13c8eba
1 parent 6dc35b9
commit 13c8eba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 18 deletions.
diff --git a/gen/go/metrics/v1/metrics.pb.go b/gen/go/metrics/v1/metrics.pb.go
diff --git a/opentelemetry/proto/metrics/v1/metrics.proto b/opentelemetry/proto/metrics/v1/metrics.proto
@@ -341,16 +341,11 @@ message SummaryDataPoint {
 
   // Represents the value at a given percentile of a distribution.
   //
-  // To support the Min and Max values of a MinMaxSumCount aggregation the
-  // following conventions are used:
-  //   - The 100th percentile is equivalent to the maximum value observed
-  //     so can be used as a stand in for the Max value.
-  //   - Set the 0th percentile to the Min value. This is mathematically
-  //     incorrect, but the most suitable way to transmit this data with the
-  //     existing metric kinds.
+  // To record Min and Max values following conventions are used:
+  // - The 100th percentile is equivalent to the maximum value observed.
+  // - The 0th percentile is equivalent to the minimum value observed.
   //
-  // For more information about work underway to better support the
-  // MinMaxSumCount aggregation refer to:
+  // See the following issue for more context:
   // https://github.com/open-telemetry/opentelemetry-proto/issues/125
   message ValueAtPercentile {
     // The percentile of a distribution. Must be in the interval