A couple of code tidies left over from PR #1499

[spadger]

Fixes a couple of style issues from #1499

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.76%. Comparing base (31d902b) to head (904d76a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1502      +/-   ##
============================================
+ Coverage     70.73%   70.76%   +0.02%     
  Complexity     2762     2762              
============================================
  Files           408      408              
  Lines          8344     8342       -2     
============================================
+ Hits           5902     5903       +1     
+ Misses         2442     2439       -3     

Flag	Coverage Δ
8.1	70.47% <100.00%> (+0.01%)	⬆️
8.2	70.67% <100.00%> (+0.01%)	⬆️
8.3	70.71% <100.00%> (-0.01%)	⬇️
8.4	70.69% <100.00%> (+0.05%)	⬆️
8.5	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/Contrib/Grpc/GrpcTransportFactory.php	71.79% <100.00%> (ø)

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d902b...904d76a. Read the comment docs.

[brettmc]

Released a new version with latest changes...

[spadger]

Thanks :)

[ChrisLightfootWild]

🤦 sorry, just realised that this causes a dependency on API 1.2.1 (see here).

[brettmc]

Ugh, yeah. Let's create a local const in GrpcTransportFactory for now.

[spadger]

Do you need me to do anything?

…

On Fri, 7 Feb 2025, 15:45 Chris Lightfoot-Wild, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Contrib/Grpc/GrpcTransportFactory.php <#1502 (comment)> : > @@ -81,13 +82,12 @@ public function create( $opts, $method, $headers, - (int) ($timeout * 1000), + (int) ($timeout * ClockInterface::MILLIS_PER_SECOND), 🤦 sorry, just realised that this causes a dependency on API 1.2.1 (see here <https://github.com/opentelemetry-php/api/blob/1.2.1/Common/Time/ClockInterface.php#L12> ). — Reply to this email directly, view it on GitHub <#1502 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABU5LCKVPBFKI4TV6FF74D2OTIIDAVCNFSM6AAAAABWRED4ZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBSGA4TIOJRGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>