Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix start timestamp in auto root span #1413

Merged

Conversation

znerol
Copy link
Contributor

@znerol znerol commented Oct 18, 2024

Problem: The start time in AutoRootSpan is recorded in milliseconds instead of nanoseconds.

Proposal: Use ClockInterface::NANOS_PER_SECOND instead of a magic value.

@znerol znerol requested a review from a team as a code owner October 18, 2024 15:44
Copy link

welcome bot commented Oct 18, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Oct 18, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit e1410ce
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/67128273a4a963000882ca5a

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (fd654b9) to head (e1410ce).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1413      +/-   ##
============================================
- Coverage     73.73%   73.56%   -0.17%     
  Complexity     2683     2683              
============================================
  Files           387      387              
  Lines          7672     7975     +303     
============================================
+ Hits           5657     5867     +210     
- Misses         2015     2108      +93     
Flag Coverage Δ
8.1 73.31% <100.00%> (-0.10%) ⬇️
8.2 73.44% <100.00%> (-0.22%) ⬇️
8.3 73.44% <100.00%> (-0.25%) ⬇️
8.4 73.49% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/AutoRootSpan.php 85.71% <100.00%> (+0.60%) ⬆️

... and 207 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd654b9...e1410ce. Read the comment docs.

@brettmc brettmc merged commit 93f2068 into open-telemetry:main Oct 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants