Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding auto-instrumentation attribute to API #1371

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 28, 2024

adding WithSpan and SpanAttribute attributes to the API. These attributes are used by an upcoming feature in auto-instrumentation which allows users to add attributes to their code to enable auto-instrumentation.

adding WithSpan and SpanAttribute attributes to the API. These attributes
are used by an upcoming feature in auto-instrumentation which allows users
to add attributes to their code to enable auto-instrumentation.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (4fc1700) to head (9949e04).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1371      +/-   ##
============================================
- Coverage     74.12%   73.98%   -0.14%     
- Complexity     2664     2666       +2     
============================================
  Files           383      385       +2     
  Lines          7636     7638       +2     
============================================
- Hits           5660     5651       -9     
- Misses         1976     1987      +11     
Flag Coverage Δ
8.1 73.72% <100.00%> (-0.03%) ⬇️
8.2 73.91% <100.00%> (-0.05%) ⬇️
8.3 73.94% <100.00%> (+0.02%) ⬆️
8.4 73.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/API/Instrumentation/SpanAttribute.php 100.00% <100.00%> (ø)
src/API/Instrumentation/WithSpan.php 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc1700...9949e04. Read the comment docs.

Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettmc brettmc merged commit bee9c64 into open-telemetry:main Aug 30, 2024
9 of 10 checks passed
@brettmc brettmc deleted the withspan_api branch January 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants