cache php extensions #1213
Merged
cache php extensions #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
============================================
- Coverage 83.19% 83.19% -0.01%
- Complexity 2257 2262 +5
============================================
Files 285 285
Lines 6422 6432 +10
============================================
+ Hits 5343 5351 +8
- Misses 1079 1081 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
optimize build times by caching php extensions for one week, particularly for 8.4/nightly which otherwise builds extensions from source each time this ended up being a little convoluted, since caching extensions does not run on failure. So, make all steps continue-on-failure for experimental builds, and add a final post job which checks the status of the steps and does a final fail.
bobstrecansky
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize build times by caching php extensions, particularly for 8.4/nightly which otherwise builds extensions from source each time.
Cache key is year+week#, so the first action each week will be particularly slow (~18m for 8.4); the other versions will be slower but tolerable at ~30s
NB that 8.4 now incorrectly reports as passing, but there are some errors visible in the overview.