Yii2 instrumentation - fix http.route for non-InlineAction #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=========================================
Coverage 85.44% 85.44%
- Complexity 965 966 +1
=========================================
Files 88 88
Lines 3915 3916 +1
=========================================
+ Hits 3345 3346 +1
Misses 570 570
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Feb 5, 2024
brettmc
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-telemetry/opentelemetry-php#1228
The previous method of detecting http.route only worked correctly if the action was an
InlineAction(which is the case for controller methods), but if it was provided in another way, it would throw and route would fallback to HTTP method. Usingidfield of baseActionclass if action is not anInlineActionto fix this.