Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tests #189

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Fixing tests #189

merged 10 commits into from
Aug 28, 2023

Conversation

ChrisLightfootWild
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild commented Aug 28, 2023

Unrelated tests are failing in #184.

I've fixed what I can; I'm lacking context with the Symfony bundle to be able to fix it. Any help appreciated!

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #189 (54e25f6) into main (1bc2e84) will decrease coverage by 6.13%.
The diff coverage is n/a.

❗ Current head 54e25f6 differs from pull request most recent head b369ad5. Consider uploading reports for the commit b369ad5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #189      +/-   ##
============================================
- Coverage     34.73%   28.60%   -6.13%     
+ Complexity      814      472     -342     
============================================
  Files            71       47      -24     
  Lines          3078     1755    -1323     
============================================
- Hits           1069      502     -567     
+ Misses         2009     1253     -756     
Flag Coverage Δ
7.4 52.29% <ø> (+6.11%) ⬆️
8.0 27.86% <ø> (-6.93%) ⬇️
8.1 27.92% <ø> (-6.90%) ⬇️
8.2 28.62% <ø> (-6.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Instrumentation/Laravel/src/HeadersPropagator.php 0.00% <ø> (ø)
...rumentation/MongoDB/src/MongoDBInstrumentation.php 0.00% <ø> (ø)
...n/MongoDB/src/MongoDBInstrumentationSubscriber.php 0.00% <ø> (ø)
...mentation/Symfony/src/RequestPropagationGetter.php 0.00% <ø> (ø)
...entation/Symfony/src/ResponsePropagationSetter.php 0.00% <ø> (ø)

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc2e84...b369ad5. Read the comment docs.

@ChrisLightfootWild ChrisLightfootWild marked this pull request as ready for review August 28, 2023 19:28
@ChrisLightfootWild ChrisLightfootWild requested a review from a team August 28, 2023 19:28
@brettmc brettmc merged commit c8e79a8 into open-telemetry:main Aug 28, 2023
51 of 55 checks passed
@ChrisLightfootWild ChrisLightfootWild deleted the fix/tests branch August 29, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants