Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL Operator release 0.44.0 #719

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Conversation

erichsueh3
Copy link
Contributor

Resolves #700 for Operator release v0.44.0

@erichsueh3 erichsueh3 requested review from a team and codeboten February 17, 2022 19:47
@erichsueh3
Copy link
Contributor Author

Looked through the Collector's changelog, and I don't think there are any migration steps necessary. Though, still unsure what exactly qualifies as a migration step, if someone could clear that up so I can understand for future reference that'd be great!

@erichsueh3
Copy link
Contributor Author

Not sure why the CI is failing, says that Build failed: the bundle, config files has been changed but the generated bundle, config files aren't up to date. Run 'make bundle' and update your PR. but I've already done that as per the release checklist

@@ -6,7 +6,7 @@ LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/
LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/
LABEL operators.operatorframework.io.bundle.package.v1=opentelemetry-operator
LABEL operators.operatorframework.io.bundle.channels.v1=alpha
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0+git
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.17.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erichsueh3 please install operator-sdk 1.17.0 and re-generate the manifest files. This will fix the issue with CI..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavolloffay, these manifest files were generated after installing operator-sdk 1.17.0; I've done it again just to make sure, and the generated manifest files remain the same

Copy link
Member

@pavolloffay pavolloffay Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you run the generation?

The following command does not change the labels in bundle.Dockerfile and bundle/metadata/annotations.yaml.

make bundle generate api-docs USER=open-telemetry VERSION=0.44.0

Copy link
Contributor Author

@erichsueh3 erichsueh3 Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make bundle USER=open-telemetry VERSION=0.44.0; this is what step 2 of RELEASE.md instructs. Should we update the documentation to use your command instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation.

Please revert this change the label should be LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0+git if you run the bundle it will get changed to v1.16.0+git.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

kind: Kustomization
images:
- name: controller
newName: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be changes in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed; these changes were made during the make bundle command, how can I discern whether or not a change made from there should be included?

CHANGELOG.md Show resolved Hide resolved
bundle/metadata/annotations.yaml Outdated Show resolved Hide resolved
@pavolloffay
Copy link
Member

CI is failing

@erichsueh3
Copy link
Contributor Author

CI is failing

Should be fixed now!

@pavolloffay
Copy link
Member

@erichsueh3 the changelog needs to be updated again

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with Pavol's suggestion to update changelog.

Overall LGTM

@erichsueh3
Copy link
Contributor Author

@pavolloffay @VineethReddy02 just updated the changelog

@pavolloffay
Copy link
Member

@erichsueh3 could you please take a look at this comment https://github.com/open-telemetry/opentelemetry-operator/pull/719/files#r811677921

@erichsueh3
Copy link
Contributor Author

@erichsueh3 could you please take a look at this comment https://github.com/open-telemetry/opentelemetry-operator/pull/719/files#r811677921

Just took a look and left a comment there

@pavolloffay
Copy link
Member

The bundle.Dockerfile should be reverted, otherwise the PR looks good to me.

@pavolloffay pavolloffay merged commit e7f2fdc into open-telemetry:main Feb 23, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* OTEL Operator release 0.44.0

* removed changes to kustomization.yaml

* removed sdk version changes

* Added to CHANGELOG

* update changelog

* revert LABEL in bundle.Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.44.0
3 participants