add healthz, readyz probes to controller manager. #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes open-telemetry#602 Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com
pavolloffay
approved these changes
Dec 6, 2021
jpkrohling
reviewed
Dec 6, 2021
jpkrohling
approved these changes
Dec 6, 2021
|
Auto-merging this. If it doesn't work, feel free to ping me and I'll merge it manually. |
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* add healthz, readyz probes to controller manager. fixes open-telemetry#602 Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com * fix manager port * run `make bundle' to update csv * nitty change flag naming to be more consistent with existing flags * fix import ordering
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* add healthz, readyz probes to controller manager. fixes open-telemetry#602 Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com * fix manager port * run `make bundle' to update csv * nitty change flag naming to be more consistent with existing flags * fix import ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add healthz, readyz probes to controller manager.
fixes #602
Signed-off-by: Adrian Kostrubiak adrian.kostrubiak@tomtom.com
I'm unclear if there's a good way to add unit/etc tests for this change. If there is, I'd welcome any ideas or suggestions.