Inject K8S_NODE_NAME environment variable when using the kubeletstats receiver #3389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iblancasa
commented
Oct 24, 2024
iblancasa
commented
- Resolves: Inject the K8S_NODE_NAME environment variable when using the kubeletstatsreceiver and serviceAccount authentication #2779
Signed-off-by: Israel Blancas <iblancas@redhat.com>
… receiver Signed-off-by: Israel Blancas <iblancas@redhat.com>
… receiver Signed-off-by: Israel Blancas <iblancas@redhat.com>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
swiatekm
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Could you add some simple unit tests for the functions you've added? It would also be good to check that the variable exists in the kubeletstatsreceiver e2e test here: https://github.com/open-telemetry/opentelemetry-operator/tree/main/tests/e2e-automatic-rbac/receiver-kubeletstats.
jaronoff97
reviewed
Oct 29, 2024
Signed-off-by: Israel Blancas <iblancas@redhat.com>
|
Done! @swiatekm @jaronoff97 |
swiatekm
approved these changes
Oct 30, 2024
jaronoff97
reviewed
Oct 30, 2024
Signed-off-by: Israel Blancas <iblancas@redhat.com>
jaronoff97
approved these changes
Nov 1, 2024
|
looks like some unit tests failures. |
Flaky unit tests in target allocator service discovery again: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.