Refresh go proxy module info on release #315
Conversation
| - name: "refresh go proxy module info on release" | ||
| run: | | ||
| OPERATOR_VERSION=$(git describe --tags) | ||
| curl https://proxy.golang.org/github.com/open-telemetry/opentelemetry-operator/@v/${OPERATOR_VERSION}.info |
There was a problem hiding this comment.
How about running go get or get install to fetch the new version instead?
There was a problem hiding this comment.
I am not sure how to fetch the latest version using go get do you mind sharing the cmd to fetch the version? Currently, I am using the same method used to create release tag which is already being used in prior step of release flow here
There was a problem hiding this comment.
go get github.com/open-telemetry/opentelemetry-operator@{VERSION}
should work. For example,
go get github.com/open-telemetry/opentelemetry-operator@v0.27.0
There was a problem hiding this comment.
Did it work to use the notation that @owais mentioned?
There was a problem hiding this comment.
the go get just pulls the dep, but I am unable to test the refresh thing as it happens after the releases. How about letting it be curl as suggested in go docs?
There was a problem hiding this comment.
I think curl is more explicit about the intentions. It would also remove the doubts on whether the call actually got to the destination. I was referring to the env var with the version, though :-)
There was a problem hiding this comment.
Switched it back to curl and I noticed during the release process we are creating operator release in create-release-github.sh using the same git cmd here so now during the release we create a new version and perform the curl on the same version with current changes.
fixes: #116