Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App for TA collector mtls e2e tests #3120

Merged

Conversation

ItielOlenick
Copy link
Contributor

Description: New app for testing that the collector was able to get secret auth details from the target allocator when communication is done over mTLS

Part of a solution for #1669

Testing:

Documentation:

@ItielOlenick ItielOlenick requested a review from a team July 11, 2024 17:50
@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 19, 2024
@swiatekm swiatekm self-requested a review August 19, 2024 14:21
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a short README.md to the directory, explaining what this is for, as it's not immediately obvious from the code.

Other than that, this looks good to me. I considered using some off the shelf application instead, but I think that'd be a comparable amount of work, and less clarity on how it was used.

@pavolloffay @jaronoff97 can you check this out and see if you're ok with it?

@jaronoff97
Copy link
Contributor

this looks great to me!

@swiatekm swiatekm merged commit eed19b2 into open-telemetry:main Aug 23, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants