Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managed resources by the collector #2876

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

pavolloffay
Copy link
Member

Resolves #2746

This is about giving a hint to OLM which objects are managed by the custom resources. The list does not have to be exhaustive.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from a team April 17, 2024 15:35
@pavolloffay pavolloffay added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 17, 2024
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the list doesn't need to be exhaustive, should it be?

@pavolloffay
Copy link
Member Author

I think we cover the most important user-facing objects.

@pavolloffay pavolloffay merged commit e58df33 into open-telemetry:main Apr 17, 2024
31 checks passed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Update managed resources by the collector

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

---------

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
rubenvp8510 pushed a commit to rubenvp8510/opentelemetry-operator that referenced this pull request May 7, 2024
* Update managed resources by the collector

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

---------

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay deleted the update-managed-resources branch May 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated optional resources manged by the operator
2 participants