Use v1beta1 in docs #2868
Merged
Use v1beta1 in docs #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
secustor
approved these changes
Apr 17, 2024
pavolloffay
added
the
Skip Changelog
jaronoff97
approved these changes
Apr 17, 2024
swiatekm
approved these changes
Apr 18, 2024
iblancasa
approved these changes
Apr 18, 2024
frzifus
reviewed
Apr 18, 2024
| @@ -599,15 +599,16 @@ For more information about multi-instrumentation feature capabilities please see | |||
| The OpenTelemetry Operator comes with an optional component, the [Target Allocator](/cmd/otel-allocator/README.md) (TA). When creating an OpenTelemetryCollector Custom Resource (CR) and setting the TA as enabled, the Operator will create a new deployment and service to serve specific `http_sd_config` directives for each Collector pod as part of that CR. It will also rewrite the Prometheus receiver configuration in the CR, so that it uses the deployed target allocator. The following example shows how to get started with the Target Allocator: | |||
|
|
|||
| ```yaml | |||
| apiVersion: opentelemetry.io/v1alpha1 | |||
| kubectl apply -f - <<EOF | |||
There was a problem hiding this comment.
Do we rly need this kubectl apply -f - <<EOF \n EOF stuff?
There was a problem hiding this comment.
it's used across the readme, but it was missing here
There was a problem hiding this comment.
It's nice for getting started
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Use v1beta1 in docs Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> --------- Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Use v1beta1 in docs Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> --------- Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
* Use v1beta1 in docs Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> --------- Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after v1beta1 is released.