Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing per-node strategy to TA CRD #2859

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Add missing per-node strategy to TA CRD #2859

merged 1 commit into from
Apr 16, 2024

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented Apr 16, 2024 •
edited
Loading

Partially addresses #2860.

@swiatekm swiatekm added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2024
@swiatekm swiatekm requested a review from a team April 16, 2024 09:17
@swiatekm swiatekm force-pushed the fix/add-ta-crd-per-node branch 2 times, most recently from 2fdf345 to b76c9e5 Compare April 16, 2024 11:32
@pavolloffay
Copy link
Member

I would consider changing the conversion from code in case a new strategy is added to the v1beta1 in future to avoid failures

@swiatekm swiatekm force-pushed the fix/add-ta-crd-per-node branch from b76c9e5 to a0f148c Compare April 16, 2024 13:25
@pavolloffay
Copy link
Member

it can be done in a separate PR

@swiatekm swiatekm force-pushed the fix/add-ta-crd-per-node branch from a0f148c to 4cefa04 Compare April 16, 2024 13:26
@swiatekm
Copy link
Contributor Author

swiatekm commented Apr 16, 2024 •
edited
Loading

I would consider changing the conversion from code in case a new strategy is added to the v1beta1 in future to avoid failures

You mean like, writing explicit conversion functions between the v1beta1 and v1alpha1 enums? Sure, I can do that.

@swiatekm swiatekm merged commit 32f4fd2 into open-telemetry:main Apr 16, 2024
31 checks passed
@swiatekm swiatekm deleted the fix/add-ta-crd-per-node branch April 16, 2024 14:01
@swiatekm swiatekm mentioned this pull request Apr 16, 2024
Closed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@swiatekm
Add missing per-node strategy to TA CRD (open-telemetry#2859)
bba5059
rubenvp8510 pushed a commit to rubenvp8510/opentelemetry-operator that referenced this pull request May 7, 2024
@swiatekm @rubenvp8510
Add missing per-node strategy to TA CRD (open-telemetry#2859)
76d2fb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swiatekm @pavolloffay