Clarify RBAC in TargetAllocator readme. Issue ref: #2734 #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
approved these changes
Mar 11, 2024
swiatekm
reviewed
Mar 11, 2024
pavolloffay
approved these changes
Mar 11, 2024
@pavolloffay The CI process erred out when I left it out initially (see screen shot below), which is why I put it in. Is there a way to bypass that? 
|
pavolloffay
added
the
Skip Changelog
It's expected, maintainers are adding skip changelog label for PRs that don't need a changelog |
Ah! TIL 😄 |
jaronoff97
reviewed
Mar 11, 2024
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
open-telemetry#2739) * Clarify RBAC in TargetAllocator readme. open-telemetry#2734 * Add changelog * Add links to PodMonitor and ServiceMonitor APIs * Add supported deployment modes * Got the PrometheusCR roles and base TA roles mixed up - fixed it now. * Remove changelog - not needed for readme update * Update cmd/otel-allocator/README.md Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com> * Update cmd/otel-allocator/README.md Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com> --------- Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated TargetAllocator README to clarify RBAC.
Link to tracking Issue(s):
Testing:
n/a - no Operator code was modified
Documentation:
Updated TargetAllocator README