-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shareProcessNamespace capability to v1alpha2 #2541
add shareProcessNamespace capability to v1alpha2 #2541
Conversation
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to run make generate
afaik we do not generate |
We don't build manifests, but we do generate the deepcopy code. |
@swiatekm-sumo Is coping a primitive values not covered in line 600? Since opentelemetry-operator/apis/v1alpha2/zz_generated.deepcopy.go Lines 598 to 600 in e2773be
|
I was confused why the documentation change was in this PR, but it looks like it's because the original PRs didn't include it. Which is strange, because the CI should fail that. I'll look into it, but this PR seems fine even though the changes are confusing. |
Oh, I thought the generated lines belong to |
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Description:
Link to tracking Issue:
Closes #2540
Testing:
Documentation: