Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error logging in collector container creation #2420

Merged

Conversation

changexd
Copy link
Contributor

@changexd changexd commented Dec 6, 2023

Description:
this fix the bug that prints out error logs without checking when creating collector container resource

@changexd changexd requested a review from a team December 6, 2023 09:24
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please add a changelog entry and we'll be good to go.

@jaronoff97 jaronoff97 merged commit 498f8fb into open-telemetry:main Dec 6, 2023
27 checks passed
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* fix logging err in collector container manifest

* add chlog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants