[Chore] Fix smoke-daemonset test case to work on multi-node cluster. #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshwarKanse
changed the title
iblancasa
approved these changes
Dec 4, 2023
pavolloffay
reviewed
Dec 4, 2023
| apiVersion: kuttl.dev/v1beta1 | ||
| kind: TestAssert | ||
| commands: | ||
| - script: ./tests/e2e/smoke-daemonset/check-daemonset.sh |
There was a problem hiding this comment.
Why do we need a script and cannot statically set the desiredNumberScheduled and numberReady
(a comment in the code would be nice)
There was a problem hiding this comment.
Added the comment.
pavolloffay
approved these changes
Dec 4, 2023
changexd
pushed a commit
to changexd/opentelemetry-operator
that referenced
this pull request
Dec 5, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: