Remove old autodetection for openshift routes, cleanup #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
commented
Nov 28, 2023
| @@ -186,6 +186,10 @@ func main() { | |||
| config.WithAutoDetect(ad), | |||
| config.WithLabelFilters(labelsFilter), | |||
| ) | |||
| err = cfg.AutoDetect() | |||
There was a problem hiding this comment.
In the future we could autodetect more things like if certain CRDs are available. We honestly should do this for Prometheus too.
…or into migrate-route-reconcilation
jaronoff97
commented
Nov 28, 2023
There was a problem hiding this comment.
I moved the tests to the reconcile_test.go file which was a much better place for it.
pavolloffay
reviewed
Nov 29, 2023
| ) | ||
|
|
||
| // Routes reconciles the route(s) required for the instance in the current context. | ||
| // TODO: This functionality should be put with the rest of reconciliation logic in the mutate.go |
There was a problem hiding this comment.
Why did we keep this? The mutate is already handling routes
There was a problem hiding this comment.
This was because the old task logic would dynamically add this to its jobs. either way, i think it's probably wholly unused.
pavolloffay
approved these changes
Nov 29, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…y#2398) * remove old autodetection, cleanup * remove unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes autodetection running on a frequency, removes old route task code. For the future we can also use this autodetection for seeing that someone has the latest CRDs installed.
Link to tracking Issue: closes #2108
Testing: Unit tests were added
Documentation: N/A