Use only target address for allocation in consistent-hashing strategy #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What did the balance of targets per collector look like after you tested this? |
The relative standard deviation of it stayed roughly the same, which for this particular environment with consistent hashing is around 0.2. |
jaronoff97
approved these changes
Nov 28, 2023
|
@swiatekm-sumo looks like a unit test failure? |
swiatekm
force-pushed
the
ta/really-consistent-hashing
branch
from
22a1466
to
ee654ed
Compare
Fixed, needed to make all the test data generators assign different target urls to their generated targets. |
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…open-telemetry#2290) Co-authored-by: Jacob Aronoff <jaronoff97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For the consistent-hashing strategy, base target allocation decisions only on the target url. This way, for a given collector count, we always assign targets with the same url to the same collector. Before, this decision was based on all target labels, and targets could therefore be moved between collectors even if collector count stayed the same.
Link to tracking Issue: #2280
Testing:
Tested this in a ~500 Node production cluster in addition to the unit tests. It behaved as expected and over time resulted in an average drop of around 10% in CPU and memory usage with around 4000 scrape targets.