Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Additional Containers to the Collector spec #1980

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Adding Additional Containers to the Collector spec #1980

merged 6 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. Adding additional container specs to support sidecars and other conta… 

    …iners in the collector pod

Signed-off-by: Matt Christiansen <matt@nikore.net>
    @nikore
    nikore committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    28456d5 View commit details
    Browse the repository at this point in the history

  2. Addressing code review comments: Improving the godoc comment, adding … 

    …changelog file
    @nikore
    nikore committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5461b23 View commit details
    Browse the repository at this point in the history

  3. Update apis/v1alpha1/opentelemetrycollector_types.go 

    Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
    @nikore @TylerHelmuth
    nikore and TylerHelmuth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    476308b View commit details
    Browse the repository at this point in the history

  4. Update apis/v1alpha1/opentelemetrycollector_types.go 

    Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
    @nikore @TylerHelmuth
    nikore and TylerHelmuth committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f1c7b4f View commit details
    Browse the repository at this point in the history

  5. Adding in an assertion that the additional container equals input

    @nikore
    nikore committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8de5619 View commit details
    Browse the repository at this point in the history

  6. Adding webhook validation and improving comments based on PR feedback

    @nikore
    nikore committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a19f9a5 View commit details
    Browse the repository at this point in the history