[chore] Use tagged images in e2e tests to not trigger docker.com rate limit #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes uses imagePullPolicy: Always for images with latest or no tag, which can trigger docker.com rate limits if one runs the e2e tests too often. Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
jaronoff97
reviewed
Feb 22, 2023
| @@ -18,6 +18,6 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: myapp | |||
| image: docker.io/avadhutp123/aspnetapp:latest # source code of the application: https://github.com/dotnet/dotnet-docker/tree/main/samples/aspnetapp | |||
| image: docker.io/avadhutp123/aspnetapp@sha256:d2e8d3415f6f12efae0369aa0a9777a58583841fb133f33e10a73adb9fb392da # source code of the application: https://github.com/dotnet/dotnet-docker/tree/main/samples/aspnetapp | |||
There was a problem hiding this comment.
@pavolloffay do you know why we're not using the dotnet images from microsoft? i.e. mcr.microsoft.com/dotnet/samples:aspnetapp?
There was a problem hiding this comment.
@jaronoff97 The reason is described in #1151
andreasgerstmayr
changed the title
iblancasa
approved these changes
Feb 23, 2023
| @@ -18,6 +18,6 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: myapp | |||
| image: docker.io/avadhutp123/aspnetapp:latest # source code of the application: https://github.com/dotnet/dotnet-docker/tree/main/samples/aspnetapp | |||
| image: docker.io/avadhutp123/aspnetapp@sha256:d2e8d3415f6f12efae0369aa0a9777a58583841fb133f33e10a73adb9fb392da # source code of the application: https://github.com/dotnet/dotnet-docker/tree/main/samples/aspnetapp | |||
There was a problem hiding this comment.
@jaronoff97 The reason is described in #1151
| @@ -20,4 +20,4 @@ spec: | |||
| - name: myapp | |||
| image: ghcr.io/anuraaga/flask-hello-world:latest | |||
There was a problem hiding this comment.
I know the problem is related to the Docker Hub images but... should we apply the same philosophy to all the images?
pavolloffay
added
the
Skip Changelog
pavolloffay
approved these changes
Feb 23, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…pen-telemetry#1499) Kubernetes uses imagePullPolicy: Always for images with latest or no tag, which can trigger docker.com rate limits if one runs the e2e tests too often. Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes uses imagePullPolicy: Always for images with latest or no tag, which can trigger docker.com rate limits if one runs the e2e tests too often.