[target-allocator] Replace deprecated gorilla/mux dependency with gin
#1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Signed-off-by: Matej Gera <matej.gera@coralogix.com>
matej-g
force-pushed
the
target-allocator-replace-gorilla-dep-with-gin
branch
from
361e78d
to
0931ab5
Compare
frzifus
approved these changes
Jan 25, 2023
|
|
||
| router := gin.Default() | ||
| router.UseRawPath = true | ||
| router.UnescapePathValues = false |
There was a problem hiding this comment.
Why is it explicit set to false?
There was a problem hiding this comment.
It is set to true by default so I'm setting it to false explicitly here. Basically these two options should provide same functionality as we had with gorilla/mux and UseEncodedPath.
If it helps I can add a comment, although if you consult the comments for the gin.Engine type it should be clearer.
pavolloffay
approved these changes
Jan 25, 2023
|
I'm rerunning the unit tests with @kristinapathak 's recent change here just to be sure we have some added confidence on changing the framework :) |
jaronoff97
approved these changes
Jan 25, 2023
kristinapathak
approved these changes
Jan 25, 2023
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Jan 31, 2023
…gin` (open-telemetry#1383) * Replace dependency and adjust HTTP methods and configuration Signed-off-by: Matej Gera <matej.gera@coralogix.com> * Add changelog Signed-off-by: Matej Gera <matej.gera@coralogix.com> Signed-off-by: Matej Gera <matej.gera@coralogix.com>
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Feb 1, 2023
…gin` (open-telemetry#1383) * Replace dependency and adjust HTTP methods and configuration Signed-off-by: Matej Gera <matej.gera@coralogix.com> * Add changelog Signed-off-by: Matej Gera <matej.gera@coralogix.com> Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Merged
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…gin` (open-telemetry#1383) * Replace dependency and adjust HTTP methods and configuration Signed-off-by: Matej Gera <matej.gera@coralogix.com> * Add changelog Signed-off-by: Matej Gera <matej.gera@coralogix.com> Signed-off-by: Matej Gera <matej.gera@coralogix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1352.
This change aims to replace the deprecated
gorilla/muxwithginwhile maintaining the functionality of current solution.Note: Due to difference in convention for path variables used by both frameworks (
gorilla/muxusing curly braces, .e.g/jobs/{job_id}/targetsvs.ginusing colon e.g./jobs/:job_id/targets), the only change will be in the reported metric label for the jobs path.Signed-off-by: Matej Gera matej.gera@coralogix.com