[new-component] Operator OpAMP Bridge Service #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 1318-remote-config-service
| var multiErr error | ||
| for key, file := range config.Config.GetConfigMap() { | ||
| if len(key) == 0 || len(file.Body) == 0 { | ||
| continue |
There was a problem hiding this comment.
Why do we continue? If there's a partial success, the config hash is no longer accurate to what's being provided. Is that okay?
There was a problem hiding this comment.
this was a choice by me to say that it's okay to have a partial success, i agree the configHash would not be accurate though. Should we just throw away everything in this case?
There was a problem hiding this comment.
I'm not sure. 😕 It seems difficult to make this function an atomic operation.
Aneurysm9
reviewed
Jan 5, 2023
frzifus
reviewed
Jan 5, 2023
iblancasa
requested changes
Jan 5, 2023
Aneurysm9
reviewed
Jan 6, 2023
jaronoff97
changed the title
jaronoff97
requested review from
Aneurysm9,
frzifus,
kristinapathak and
iblancasa
|
@jaronoff97 it would be great to have your feedback on OpAMP spec and OpAMP Go as you work on this capability of the operator. Please feel free to open issues in OpAMP repos or ping me if you have any questions. |
Aneurysm9
approved these changes
Jan 10, 2023
iblancasa
approved these changes
Jan 11, 2023
pavolloffay
approved these changes
Jan 11, 2023
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Jan 31, 2023
* Begin the journey * Some hacks to functionality * Fix create bug, getting prepped for refactor * Some reorganization and cleaning, added tests * Add deletion and dockerfile * Add logic for specifying allowed components * Linting, CI, header * Makefile CI * Added comments, created an object for use by the applied keys map * Fix makefile, update to use require * IMports * updated from comments * Improved logging, working dockerfile * Rename the whole thing * Change service name * Update from feedback
iblancasa
pushed a commit
to iblancasa/opentelemetry-operator
that referenced
this pull request
Feb 1, 2023
* Begin the journey * Some hacks to functionality * Fix create bug, getting prepped for refactor * Some reorganization and cleaning, added tests * Add deletion and dockerfile * Add logic for specifying allowed components * Linting, CI, header * Makefile CI * Added comments, created an object for use by the applied keys map * Fix makefile, update to use require * IMports * updated from comments * Improved logging, working dockerfile * Rename the whole thing * Change service name * Update from feedback
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Begin the journey * Some hacks to functionality * Fix create bug, getting prepped for refactor * Some reorganization and cleaning, added tests * Add deletion and dockerfile * Add logic for specifying allowed components * Linting, CI, header * Makefile CI * Added comments, created an object for use by the applied keys map * Fix makefile, update to use require * IMports * updated from comments * Improved logging, working dockerfile * Rename the whole thing * Change service name * Update from feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part 1 of #1318
A few things before this is ready: