Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim unnecessary otelcol operator verbs #1222

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Allex1
Copy link
Contributor

@Allex1 Allex1 commented Nov 4, 2022

related to #1202
Signed-off-by: birca Allex21ro@yahoo.com

@Allex1 Allex1 requested a review from a team November 4, 2022 09:15
@Allex1 Allex1 force-pushed the main branch 3 times, most recently from d3f1113 to f538279 Compare November 4, 2022 09:56
Copy link

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Allex1 Allex1 force-pushed the main branch 2 times, most recently from 5d2b0c7 to 0a4ab6c Compare November 7, 2022 07:32
Signed-off-by: birca <Allex21ro@yahoo.com>
@Allex1
Copy link
Contributor Author

Allex1 commented Nov 7, 2022

looks like you need make bundle to update the CSV https://github.com/open-telemetry/opentelemetry-operator/actions/runs/3392835652/jobs/5639480970#step:6:227

@damemi done , but the command was make ensure-generate-is-noop as make bundle uses local username which causes confusion. Should we update the message in the CI to reflect that ?

@pavolloffay pavolloffay merged commit 9528bdd into open-telemetry:main Nov 7, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Signed-off-by: birca <Allex21ro@yahoo.com>

Signed-off-by: birca <Allex21ro@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants