Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip .NET auto-instrumentation if OTEL_DOTNET_AUTO_HOME env var is already set #1177

Merged
merged 18 commits into from
Oct 19, 2022
Merged

Skip .NET auto-instrumentation if OTEL_DOTNET_AUTO_HOME env var is already set #1177

merged 18 commits into from
Oct 19, 2022

Commits on Oct 5, 2022

  1. skips env var injection and sdk configurations if agent injection is … 

    …skipped
    @avadhut123pisal
    avadhut123pisal committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    34127db View commit details
    Browse the repository at this point in the history

  2. mutate container at the last of SDK injection step

    @avadhut123pisal
    avadhut123pisal committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    134c44e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera… 

    …tor into prevent-incomplete-auto-instrumentation
    @avadhut123pisal
    avadhut123pisal committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    928b2e0 View commit details
    Browse the repository at this point in the history

  2. validate first and then mutate the container with env variables

    @avadhut123pisal
    avadhut123pisal committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    ff8d0e3 View commit details
    Browse the repository at this point in the history

  3. fixes go lint issues

    @avadhut123pisal
    avadhut123pisal committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    2a6569c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. incorporates review comments

    @avadhut123pisal
    avadhut123pisal committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    0b2fce7 View commit details
    Browse the repository at this point in the history

  2. fixes go lint issue

    @avadhut123pisal
    avadhut123pisal committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    d703287 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into prevent-incomplete-auto-instrumentation

    @avadhut123pisal
    avadhut123pisal authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    cea2e0d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. removes return statement in case of failed instrumentation

    @avadhut123pisal
    avadhut123pisal committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    2710133 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'prevent-incomplete-auto-instrumentation' of github.com:… 

    …avadhut123pisal/opentelemetry-operator into prevent-incomplete-auto-instrumentation
    @avadhut123pisal
    avadhut123pisal committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    400fc2a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera… 

    …tor into skip-instrumentation-if-otel-dotnet-auto-home-set
    @avadhut123pisal
    avadhut123pisal committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    04d4b57 View commit details
    Browse the repository at this point in the history

  2. skips auto-instrumentation if OTEL_DOTNET_AUTO_HOME is already set

    @avadhut123pisal
    avadhut123pisal committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    3faad7c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. use errors.New() to get the error object 

    use errors.New() to get the error object instead of fmt.Errorf()

Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @avadhut123pisal @pellared
    avadhut123pisal and pellared authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    306e1be View commit details
    Browse the repository at this point in the history

  2. use errors.New() to get the error object 

    use errors.New() to get the error object instead of fmt.Errorf()

Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @avadhut123pisal @pellared
    avadhut123pisal and pellared authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    e405425 View commit details
    Browse the repository at this point in the history

  3. replaces fmt.Errorf with error.New

    @avadhut123pisal
    avadhut123pisal committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ee33528 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'skip-instrumentation-if-otel-dotnet-auto-home-set' of g… 

    …ithub.com:avadhut123pisal/opentelemetry-operator into skip-instrumentation-if-otel-dotnet-auto-home-set
    @avadhut123pisal
    avadhut123pisal committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    3e036f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera… 

    …tor into skip-instrumentation-if-otel-dotnet-auto-home-set
    @avadhut123pisal
    avadhut123pisal committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    88caa92 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera… 

    …tor into skip-instrumentation-if-otel-dotnet-auto-home-set
    @avadhut123pisal
    avadhut123pisal committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    906f746 View commit details
    Browse the repository at this point in the history