Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang 1.19 #1021

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Use golang 1.19 #1021

merged 1 commit into from
Sep 1, 2022

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay p.loffay@gmail.com

@pavolloffay pavolloffay marked this pull request as ready for review August 3, 2022 08:19
@pavolloffay pavolloffay requested a review from a team August 3, 2022 08:19
- name: Check out code into the Go module directory
uses: actions/checkout@v3

- name: Lint
uses: golangci/golangci-lint-action@v3
with:
args: -v
version: v1.45
version: v1.47
Copy link
Member Author

@pavolloffay pavolloffay Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci does not support go 1.19 just yet golangci/golangci-lint#3037

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot get the linter to work. see as well golangci/golangci-lint#2374 (comment)

@pavolloffay
Copy link
Member Author

I am happy to merge this and book an issue to update golangci once it supports golang 1.19

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh.. now iam confused by the diff? The ci worked, but there is no downgrade in the files?

@pavolloffay
Copy link
Member Author

but there is no downgrade in the files?

what downgrade?

@frzifus
Copy link
Member

frzifus commented Aug 3, 2022

but there is no downgrade in the files?

what downgrade?

This one? 9e6d86b

@pavolloffay
Copy link
Member Author

There is no downgrade, I have reverted it back to the original version.

//Following Otel Doc: Configuring a receiver does not enable it. The receivers are enabled via pipelines within the service section.
//GetEnabledReceivers returns all enabled receivers as a true flag set. If it can't find any receiver, it will return a nil interface.
func GetEnabledReceivers(logger logr.Logger, config map[interface{}]interface{}) map[interface{}]bool {
// Following Otel Doc: Configuring a receiver does not enable it. The receivers are enabled via pipelines within the service section.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint was complaining that there was no space

@@ -17,7 +17,7 @@ package reconcile
import (
"context"
"fmt"
"io/ioutil"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io/ioutil is deprecated

@pavolloffay
Copy link
Member Author

PR is ready to be merged

@pavolloffay
Copy link
Member Author

cc) @VineethReddy02 @jpkrohling @yuriolisa

@yuriolisa
Copy link
Contributor

@pavolloffay, could you please rebase it?

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

PR rebased.

@pavolloffay pavolloffay merged commit c1546e3 into open-telemetry:main Sep 1, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants