Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoinstrumentation Nodejs] use http exporter when OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf #3412

Closed
atsu85 opened this issue Nov 1, 2024 · 0 comments · Fixed by #3413
Closed

[Autoinstrumentation Nodejs] use http exporter when OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf #3412

atsu85 opened this issue Nov 1, 2024 · 0 comments · Fixed by #3413
Labels
enhancement New feature or request needs triage

Comments

@atsu85
Copy link
Contributor

atsu85 commented Nov 1, 2024 •
edited
Loading

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

allow exporting traces to endpoints that only accept http/protobuf instead of grpc

Describe the solution you'd like

when standard environment variable OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf, then use
@opentelemetry/exporter-trace-otlp-http
instead of default
@opentelemetry/exporter-trace-otlp-grpc

Describe alternatives you've considered

none - this is standard approach that works with other autoinstrumentation solutions

Additional context

This is simple change, that affects just initializing traceExporter, that is currently done on this line
@atsu85 atsu85 added enhancement New feature or request needs triage labels Nov 1, 2024
atsu85 pushed a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for exporting trace…
d38b65f 
…s via http

Closes open-telemetry#3412
@atsu85 atsu85 mentioned this issue Nov 1, 2024
Merged
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
feat(exporter): Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for…
3074445 
… exporting traces via http

Closes open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
feat(exporter): Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for…
0487e20 
… exporting traces via http

Closes open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
refactor(exporter): extract function to create traces exporter
ca43ff4 
Issue open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
feat(exporter): Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for…
b951f71 
… exporting traces via http

Closes open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
refactor(exporter): extract function to create traces exporter
13c044f 
Issue open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 1, 2024
@atsu85
feat(exporter): Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for…
2d13476 
… exporting traces via http

Closes open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 5, 2024
@atsu85
refactor(exporter): extract function to create traces exporter
a21f949 
Issue open-telemetry#3412
atsu85 added a commit to atsu85/opentelemetry-operator that referenced this issue Nov 5, 2024
@atsu85
feat(exporter): Support OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf for…
a22b2d5 
… exporting traces via http

Closes open-telemetry#3412
@jj22ee jj22ee mentioned this issue Nov 27, 2024
Merged
pxaws pushed a commit to aws-observability/aws-otel-js-instrumentation that referenced this issue Nov 27, 2024
@jj22ee
[Chore] Cleanup comment regarding OTLP Protocols (#124)
cd8377c 
*Issue #, if available:*
`gRPC` is the already default exporter as of the OTel JS version that we
are dependent on (See:
open-telemetry/opentelemetry-operator#3412)
Closing as Python's issue with `gRPC` does not apply to NodeJS.

*Description of changes:*
Cleanup comment regarding OTLP Protocols


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
@alexkruc alexkruc mentioned this issue Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs triage
Projects
None yet
Milestone
No milestone
1 participant
@atsu85