Adding in an assertion that the additional container equals input

bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml

@@ -31,7 +31,7 @@ metadata:
     categories: Logging & Tracing
     certified: "false"
     containerImage: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator
-    createdAt: "2023-08-04T20:52:54Z"
+    createdAt: "2023-08-08T21:23:14Z"
     description: Provides the OpenTelemetry components, including the Collector
     operators.operatorframework.io/builder: operator-sdk-v1.29.0
     operators.operatorframework.io/project_layout: go.kubebuilder.io/v3

bundle/manifests/opentelemetry.io_opentelemetrycollectors.yaml

@@ -66,8 +66,8 @@ spec:
               additionalContainers:
                 description: "AdditionalContainers allows injecting additional containers
                   into the Collector's pod definition. These sidecar containers can
-                  be used to authentication proxies, logging shipping sidecars, agents
-                  for shipping to metrics to their cloud, or in general sidecars that
+                  be used for authentication proxies, logging shipping sidecars, agents
+                  for shipping metrics to their cloud, or in general sidecars that
                   do not support automatic injection. This option only applies to
                   Deployment, DaemonSet, and StatefulSet deployments of the collector.
                   It does not apply to the sidecar method. More info: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/

config/crd/bases/opentelemetry.io_opentelemetrycollectors.yaml

@@ -63,8 +63,8 @@ spec:
               additionalContainers:
                 description: "AdditionalContainers allows injecting additional containers
                   into the Collector's pod definition. These sidecar containers can
-                  be used to authentication proxies, logging shipping sidecars, agents
-                  for shipping to metrics to their cloud, or in general sidecars that
+                  be used for authentication proxies, logging shipping sidecars, agents
+                  for shipping metrics to their cloud, or in general sidecars that
                   do not support automatic injection. This option only applies to
                   Deployment, DaemonSet, and StatefulSet deployments of the collector.
                   It does not apply to the sidecar method. More info: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/

docs/api.md

@@ -3615,7 +3615,7 @@ OpenTelemetryCollectorSpec defines the desired state of OpenTelemetryCollector.
         <td><b><a href="#opentelemetrycollectorspecadditionalcontainersindex">additionalContainers</a></b></td>
         <td>[]object</td>
         <td>
-          AdditionalContainers allows injecting additional containers into the Collector's pod definition. These sidecar containers can be used to authentication proxies, logging shipping sidecars, agents for shipping to metrics to their cloud, or in general sidecars that do not support automatic injection. This option only applies to Deployment, DaemonSet, and StatefulSet deployments of the collector. It does not apply to the sidecar method. More info: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/ 
+          AdditionalContainers allows injecting additional containers into the Collector's pod definition. These sidecar containers can be used for authentication proxies, logging shipping sidecars, agents for shipping metrics to their cloud, or in general sidecars that do not support automatic injection. This option only applies to Deployment, DaemonSet, and StatefulSet deployments of the collector. It does not apply to the sidecar method. More info: https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/ 
  Container names managed by the operator: * `otc-container` 
  Overriding containers managed by the operator is outside the scope of what the maintainers will support and by doing so, you wil accept the risk of it breaking things.<br/>
         </td>

internal/manifests/collector/daemonset_test.go

@@ -329,4 +329,5 @@ func TestDaemonSetAdditionalContainer(t *testing.T) {
 	assert.Equal(t, "8888", d.Annotations["prometheus.io/port"])
 	assert.Equal(t, "/metrics", d.Annotations["prometheus.io/path"])
 	assert.Len(t, d.Spec.Template.Spec.Containers, 2)
+	assert.Equal(t, v1.Container{Name: "test"}, d.Spec.Template.Spec.Containers[0])
 }

internal/manifests/collector/deployment_test.go

@@ -443,4 +443,5 @@ func TestDeploymentAdditionalContainers(t *testing.T) {
 	assert.Equal(t, "8888", d.Annotations["prometheus.io/port"])
 	assert.Equal(t, "/metrics", d.Annotations["prometheus.io/path"])
 	assert.Len(t, d.Spec.Template.Spec.Containers, 2)
+	assert.Equal(t, v1.Container{Name: "test"}, d.Spec.Template.Spec.Containers[0])
 }

internal/manifests/collector/statefulset_test.go

@@ -440,4 +440,5 @@ func TestStatefulSetAdditionalContainers(t *testing.T) {
 	assert.Equal(t, "8888", s.Annotations["prometheus.io/port"])
 	assert.Equal(t, "/metrics", s.Annotations["prometheus.io/path"])
 	assert.Len(t, s.Spec.Template.Spec.Containers, 2)
+	assert.Equal(t, v1.Container{Name: "test"}, s.Spec.Template.Spec.Containers[0])
 }