Skip to content

Commit

Permalink
Pr1680 (#2819)
Browse files Browse the repository at this point in the history
* Update OpenTelemetryCollectorSpec.Config docs

The Config field contains YAML, not JSON.

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

---------

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Co-authored-by: James Roper <james@jazzy.id.au>
  • Loading branch information
pavolloffay and jroper authored Apr 5, 2024
1 parent 68bb0ad commit 8b450d7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apis/v1alpha1/opentelemetrycollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ type OpenTelemetryCollectorSpec struct {
// ImagePullPolicy indicates the pull policy to be used for retrieving the container image (Always, Never, IfNotPresent)
// +optional
ImagePullPolicy v1.PullPolicy `json:"imagePullPolicy,omitempty"`
// Config is the raw JSON to be used as the collector's configuration. Refer to the OpenTelemetry Collector documentation for details.
// Config is the raw YAML to be used as the collector's configuration. Refer to the OpenTelemetry Collector documentation for details.
// +required
Config string `json:"config,omitempty"`
// VolumeMounts represents the mount points to use in the underlying collector deployment(s)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2239,7 +2239,7 @@ spec:
type: integer
type: object
config:
description: Config is the raw JSON to be used as the collector's
description: Config is the raw YAML to be used as the collector's
configuration. Refer to the OpenTelemetry Collector documentation
for details.
type: string
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2236,7 +2236,7 @@ spec:
type: integer
type: object
config:
description: Config is the raw JSON to be used as the collector's
description: Config is the raw YAML to be used as the collector's
configuration. Refer to the OpenTelemetry Collector documentation
for details.
type: string
Expand Down
2 changes: 1 addition & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -10312,7 +10312,7 @@ for the OpenTelemetryCollector workload.<br/>
<td><b>config</b></td>
<td>string</td>
<td>
Config is the raw JSON to be used as the collector's configuration. Refer to the OpenTelemetry Collector documentation for details.<br/>
Config is the raw YAML to be used as the collector's configuration. Refer to the OpenTelemetry Collector documentation for details.<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down

0 comments on commit 8b450d7

Please sign in to comment.