Establish Autogenerated IDs for operators with unspecified IDs #246

Mrod1598 · 2021-08-25T20:56:15Z

Resolves #105

…y-log-collection into plugin-id-testing

…y-log-collection into fix-plugin-inputs

codecov · 2021-08-25T20:59:35Z

Codecov Report

Merging #246 (99125fb) into main (0e52f2f) will increase coverage by 0.7%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #246     +/-   ##
=======================================
+ Coverage   75.6%   76.3%   +0.7%     
=======================================
  Files         95      94      -1     
  Lines       4450    4434     -16     
=======================================
+ Hits        3367    3386     +19     
+ Misses       752     718     -34     
+ Partials     331     330      -1

Impacted Files	Coverage Δ
operator/config.go	`100.0% <ø> (ø)`
operator/helper/operator.go	`94.1% <100.0%> (+0.1%)`	⬆️
pipeline/config.go	`91.1% <100.0%> (+4.0%)`	⬆️
operator/builtin/input/journald/journald.go	`52.8% <0.0%> (+0.4%)`	⬆️
operator/builtin/input/tcp/tcp.go	`74.5% <0.0%> (+1.6%)`	⬆️

djaglowski

I like how simple this is looking to be.

My biggest area of concern is with plugins. Have you determined whether they are affected by this, and if so how?

pipeline/config.go

pipeline/config_test.go

pipeline/config.go

pipeline/config_test.go

djaglowski

Looking good. Just a few more things.

testutil/operator_builder.go

pipeline/config_test.go

djaglowski

Nice work @Mrod1598!

Mrod1598 added 30 commits May 3, 2021 13:03

Add auto generated IDs to operators

2b013ec

Move generation spot

a993f0b

Add Testing

d015377

Update where IDs are changed

7e4cace

Add testing for OutputIDs

7358fff

Clean up diff

93a93dd

Add Error handling

3c268c5

Fix CI

7db86f8

Add testing for IDs

3034fc0

Test Ops is pipeline

dcc2aa6

Add testing template

a09b457

Change how default outputs are set

fe03272

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

f01804d

…y-log-collection into plugin-id-testing

Add testing for outputs

733ae20

Remove old default outputs func

1800ef9

Add ID testing

cc92043

Change how default outputs are set

260b951

Add testing for output handling

43c5b96

Merge in main

ac2b38c

Update Tests

9782118

Update mock comment

d193899

Implement PR feedback

dc78c19

Update comment

705cc0c

Implement PR feedback

37f8e0d

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

68a9e70

…y-log-collection into fix-plugin-inputs

Merge In Plugin-input-fix

3e97801

Merge in main

b1c61b4

Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…

1fab496

…y-log-collection into autogen-ids

WIP

fced5e3

Update test

cfc67f7

Mrod1598 requested a review from a team August 25, 2021 20:56

Mrod1598 marked this pull request as draft August 25, 2021 20:58

Remove error return value

709d89b

Mrod1598 marked this pull request as ready for review August 25, 2021 21:15

djaglowski reviewed Sep 2, 2021

View reviewed changes

pipeline/config.go Outdated Show resolved Hide resolved

pipeline/config_test.go Outdated Show resolved Hide resolved

pipeline/config.go Show resolved Hide resolved

pipeline/config_test.go Show resolved Hide resolved

pipeline/config_test.go Show resolved Hide resolved

PR Feedback

68f6b1f

djaglowski reviewed Sep 7, 2021

View reviewed changes

testutil/operator_builder.go Show resolved Hide resolved

Mrod1598 commented Sep 7, 2021

View reviewed changes

pipeline/config_test.go Show resolved Hide resolved

Rename test helper file

99125fb

djaglowski approved these changes Sep 8, 2021

View reviewed changes

djaglowski merged commit 049d0cb into open-telemetry:main Sep 8, 2021

djaglowski deleted the autogen-ids branch September 8, 2021 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Establish Autogenerated IDs for operators with unspecified IDs #246

Establish Autogenerated IDs for operators with unspecified IDs #246

Mrod1598 commented Aug 25, 2021

codecov bot commented Aug 25, 2021 •

edited

Loading

djaglowski left a comment

djaglowski left a comment

djaglowski left a comment

Establish Autogenerated IDs for operators with unspecified IDs #246

Establish Autogenerated IDs for operators with unspecified IDs #246

Conversation

Mrod1598 commented Aug 25, 2021

codecov bot commented Aug 25, 2021 • edited Loading

Codecov Report

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 25, 2021 •

edited

Loading