Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Fix default output #186

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

Mrod1598
Copy link
Contributor

Resolves #185

@Mrod1598 Mrod1598 changed the title Fix defaultoutput Fix default output Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #186 (6a2bc34) into main (cc61797) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #186   +/-   ##
=====================================
  Coverage   75.5%   75.6%           
=====================================
  Files         95      95           
  Lines       4360    4360           
=====================================
+ Hits        3296    3299    +3     
+ Misses       740     738    -2     
+ Partials     324     323    -1     
Impacted Files Coverage Δ
agent/builder.go 91.6% <100.0%> (+0.4%) ⬆️
pipeline/config.go 87.0% <100.0%> (-0.8%) ⬇️
plugin/config.go 60.6% <100.0%> (ø)
operator/builtin/input/tcp/tcp.go 74.5% <0.0%> (+1.6%) ⬆️
testutil/mocks.go 74.1% <0.0%> (+3.2%) ⬆️

agent/builder_test.go Outdated Show resolved Hide resolved
agent/builder_test.go Outdated Show resolved Hide resolved
agent/builder_test.go Outdated Show resolved Hide resolved
agent/builder_test.go Outdated Show resolved Hide resolved
pipeline/config.go Outdated Show resolved Hide resolved
pipeline/config.go Outdated Show resolved Hide resolved
@rockb1017
Copy link
Contributor

awesome. great the root cause is already figured out! thank you!

@djaglowski djaglowski marked this pull request as ready for review June 15, 2021 16:17
@djaglowski djaglowski requested a review from a team June 15, 2021 16:17
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Mrod1598!

@djaglowski djaglowski merged commit 44b6bf5 into open-telemetry:main Jun 15, 2021
@djaglowski djaglowski deleted the fix-default-output branch June 15, 2021 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent builder does not respect WithDefaultOutput
3 participants