Adding Binary to Release #1553
Merged
Adding Binary to Release #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the issues I am having is I am not sure how to test this change. I do not have the infrastructure setup in my fork to test the workflows. Does anyone have any suggestions on how to test this workflow change? |
|
Okay, you can see releases using this code here: https://github.com/webfinesse/opentelemetry-lambda/releases I want to delete these releases as they are obviously unofficial, however it shows that my changes work. Workflow runs can be seen here: https://github.com/webfinesse/opentelemetry-lambda/actions |
tylerbenson
reviewed
Oct 15, 2024
tylerbenson
approved these changes
Oct 16, 2024
serkan-ozal
reviewed
Oct 16, 2024
tylerbenson
approved these changes
Oct 17, 2024
serkan-ozal
approved these changes
Oct 18, 2024
|
Thanks for the contribution. We'll wait for the next release to see how well this works. |
tylerbenson
added
the
github_actions
|
Thanks for adding this. It worked great! https://github.com/open-telemetry/opentelemetry-lambda/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to several GitHub Actions workflows to enhance their functionality and permissions. The most important changes involve modifying permissions and adding steps to upload binaries to releases.
Permissions updates:
contentspermission fromreadtowritein.github/workflows/release-layer-collector.yml,.github/workflows/release-layer-java.yml,.github/workflows/release-layer-nodejs.yml,.github/workflows/release-layer-python.yml, and.github/workflows/release-layer-ruby.ymlto allow for writing content. [1] [2] [3] [4] [5]Job updates:
.github/workflows/release-layer-collector.yml..github/workflows/release-layer-java.yml..github/workflows/release-layer-nodejs.yml..github/workflows/release-layer-python.yml..github/workflows/release-layer-ruby.yml.resolves #1548
secrets.GITHUB_TOKENis set. If this is setup differently, please let me know.