Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename registry to provider #748

Closed

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 29, 2020

Fixes #740

@dyladan
Copy link
Member Author

dyladan commented Jan 29, 2020

pushed the wrong thing

@dyladan dyladan closed this Jan 29, 2020
@dyladan dyladan deleted the rename-provider branch January 29, 2020 21:34
@dyladan dyladan restored the rename-provider branch January 29, 2020 21:35
@codecov-io
Copy link

Codecov Report

Merging #748 into master will increase coverage by 3.34%.
The diff coverage is 97.23%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   92.47%   95.82%   +3.34%     
==========================================
  Files         234      175      -59     
  Lines       10475     8064    -2411     
  Branches      944      728     -216     
==========================================
- Hits         9687     7727    -1960     
+ Misses        788      337     -451
Impacted Files Coverage Δ
...metry-core/src/trace/instrumentation/BasePlugin.ts 81.57% <100%> (-5.27%) ⬇️
.../opentelemetry-plugin-ioredis/test/ioredis.test.ts 94.63% <100%> (ø) ⬆️
...ry-plugin-dns/test/functionals/dns-disable.test.ts 100% <100%> (ø) ⬆️
...lugin-https/test/functionals/https-disable.test.ts 100% <100%> (ø) ⬆️
...try-propagator-jaeger/src/JaegerHttpTraceFormat.ts 95.65% <100%> (ø) ⬆️
.../opentelemetry-plugin-pg-pool/test/pg-pool.test.ts 88.09% <100%> (ø) ⬆️
...lugin-https/test/functionals/https-package.test.ts 98.48% <100%> (ø) ⬆️
...ackages/opentelemetry-node/test/NodeTracer.test.ts 100% <100%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <100%> (ø) ⬆️
...plugin-https/test/functionals/https-enable.test.ts 96.11% <100%> (ø) ⬆️
... and 103 more

@Flarna Flarna deleted the rename-provider branch August 12, 2020 23:14
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Registry to Provider
2 participants