Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(getting-started): Added a TypeScript version for Getting Started Guide #673

Merged
merged 30 commits into from
Jan 9, 2020

Conversation

nstawski
Copy link
Contributor

@nstawski nstawski commented Jan 7, 2020

Which problem is this PR solving?

Short description of the changes

  • Added a new guide and examples for TypeScript; added links to the original README

@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #673 into master will decrease coverage by 5.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   94.97%   89.83%   -5.14%     
==========================================
  Files         187      213      +26     
  Lines        8867    10177    +1310     
  Branches      771      933     +162     
==========================================
+ Hits         8421     9143     +722     
- Misses        446     1034     +588
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
... and 68 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

getting-started/ts-example/README.md Outdated Show resolved Hide resolved
getting-started/ts-example/README.md Outdated Show resolved Hide resolved
getting-started/ts-example/README.md Show resolved Hide resolved
getting-started/ts-example/README.md Show resolved Hide resolved
getting-started/ts-example/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Mayur Kale <mayurkale@google.com>
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the tracing.ts file, but I don't see where it is imported by app.ts.

@nstawski
Copy link
Contributor Author

nstawski commented Jan 8, 2020

I see the tracing.ts file, but I don't see where it is imported by app.ts.

It is not, it is ran by a command ts-node -r ./tracing.ts app.ts as outlined in the guide.

@nstawski
Copy link
Contributor Author

nstawski commented Jan 8, 2020

@dyladan @mayurkale22 re-requested the review.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) and removed Awaiting reviewer feedback labels Jan 8, 2020
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. added few comments.

getting-started/README.md Outdated Show resolved Hide resolved
getting-started/ts-example/README.md Outdated Show resolved Hide resolved
getting-started/ts-example/README.md Show resolved Hide resolved
@mayurkale22 mayurkale22 merged commit 059595a into open-telemetry:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants