-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exporter-zipkin)!: do not read environment variables from window #5465
Open
pichlermarc
wants to merge
6
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:feat/migrate-from-getenv-zipkin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(exporter-zipkin)!: do not read environment variables from window #5465
pichlermarc
wants to merge
6
commits into
open-telemetry:main
from
dynatrace-oss-contrib:feat/migrate-from-getenv-zipkin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
commented
Feb 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 308 308
Lines 7971 7974 +3
Branches 1677 1679 +2
=======================================
+ Hits 7565 7568 +3
Misses 406 406
|
4 tasks
trentm
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Migrates from getEnv() to using the new get*FromEnv() methods added in #5443. Also inlines the defaults. This drops
"env var configuration" (via
window.OTEL_*
) in browser environments.This breaking change now will enable us to split the env var config code completely in a non-breaking feature release later.
Refs #5217
Type of change
How Has This Been Tested?