Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-zipkin)!: do not read environment variables from window #5465

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Migrates from getEnv() to using the new get*FromEnv() methods added in #5443. Also inlines the defaults. This drops
"env var configuration" (via window.OTEL_*) in browser environments.

This breaking change now will enable us to split the env var config code completely in a non-breaking feature release later.

Refs #5217

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Existing tests (browser behavior for this was untested, so nothing is added or removed)

@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Feb 13, 2025
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Feb 13, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner February 13, 2025 09:37
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (7438735) to head (6711ebb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5465   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         308      308           
  Lines        7971     7974    +3     
  Branches     1677     1679    +2     
=======================================
+ Hits         7565     7568    +3     
  Misses        406      406           
Files with missing lines Coverage Δ
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants