-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(semantic-conventions): docs on entry-points, deprecations; improve some deprecation messages #5166
chore(semantic-conventions): docs on entry-points, deprecations; improve some deprecation messages #5166
Conversation
… how to migrate from the deprecated versions of this package
…y-point when relevant
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5166 +/- ##
==========================================
- Coverage 94.57% 94.56% -0.02%
==========================================
Files 314 314
Lines 7961 7961
Branches 1600 1600
==========================================
- Hits 7529 7528 -1
- Misses 432 433 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Too bad we caused such confusion with the deprecations but i think the package overall is better with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few notes for the guidelines. Thank you for working on this!
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
@JamieDanielson pointed out that copying definitions for unstable semconv constants is recommended: https://opentelemetry.io/docs/specs/semconv/non-normative/code-generation/#stability-and-versioning I've added that as an option alternative to depending on a pinned version and using the "incubating" entry point. |
Thinking through this more... while it may not be a big deal for someone to pin now when only http is stable, it will become a bigger issue when the next wave of stable attributes come through (if there are changes). This would mean folks have the option to either pin and miss out on new stable attributes, or unpin and risk breaking changes. I'm leaning even more heavily now toward copying attributes, but am fine with that as a follow-up. |
Moved to #5182 |
This adds a few things to the readme: more intro content, notes on using the "incubating" entry-point, a section clarifying the various deprecations and how to upgrade.
This also tweaks the
@deprecated
messages in the old usage forms, mainly to add a link to the README section on the "incubating" entry-point when the suggested new constant is only in the incubating entry-point.Closes: #5025