Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semantic-conventions): docs on entry-points, deprecations; improve some deprecation messages #5166

Merged
merged 13 commits into from
Nov 20, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Nov 15, 2024

This adds a few things to the readme: more intro content, notes on using the "incubating" entry-point, a section clarifying the various deprecations and how to upgrade.

This also tweaks the @deprecated messages in the old usage forms, mainly to add a link to the README section on the "incubating" entry-point when the suggested new constant is only in the incubating entry-point.

Closes: #5025

@trentm trentm self-assigned this Nov 15, 2024
@trentm trentm requested a review from a team as a code owner November 15, 2024 18:11
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (0ee9a27) to head (859f2d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5166      +/-   ##
==========================================
- Coverage   94.57%   94.56%   -0.02%     
==========================================
  Files         314      314              
  Lines        7961     7961              
  Branches     1600     1600              
==========================================
- Hits         7529     7528       -1     
- Misses        432      433       +1     

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

trentm and others added 3 commits November 18, 2024 16:18
Co-authored-by: Jackson Weber <47067795+JacksonWeber@users.noreply.github.com>
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Too bad we caused such confusion with the deprecations but i think the package overall is better with the changes.

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few notes for the guidelines. Thank you for working on this!

semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
trentm and others added 2 commits November 19, 2024 12:46
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
@trentm
Copy link
Contributor Author

trentm commented Nov 19, 2024

@JamieDanielson pointed out that copying definitions for unstable semconv constants is recommended: https://opentelemetry.io/docs/specs/semconv/non-normative/code-generation/#stability-and-versioning
I'd known that Java was recommending this, but hadn't realized that suggestion made it into the (granted "non-normative") part of the spec.

I've added that as an option alternative to depending on a pinned version and using the "incubating" entry point.
However, do you think we should reverse the suggestion and have the first suggestion be copying the definitions?
(This could be done in a separate PR.)

@JamieDanielson
Copy link
Member

I've added that as an option alternative to depending on a pinned version and using the "incubating" entry point. However, do you think we should reverse the suggestion and have the first suggestion be copying the definitions? (This could be done in a separate PR.)

Thinking through this more... while it may not be a big deal for someone to pin now when only http is stable, it will become a bigger issue when the next wave of stable attributes come through (if there are changes). This would mean folks have the option to either pin and miss out on new stable attributes, or unpin and risk breaking changes. I'm leaning even more heavily now toward copying attributes, but am fine with that as a follow-up.

@trentm
Copy link
Contributor Author

trentm commented Nov 20, 2024

I'm leaning even more heavily now toward copying attributes, but am fine with that as a follow-up.

Moved to #5182

@trentm trentm added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Nov 20, 2024
Merged via the queue into open-telemetry:main with commit b7c03d2 Nov 20, 2024
21 checks passed
@trentm trentm deleted the tm-semconv-deprecated-warnings branch December 11, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@opentelemetry/semantic-conventions deprecated warnings point to missing exports
6 participants