Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk-node): fix typo FomEnv → FromEnv #5146

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix(sdk-node): fix typo FomEnv → FromEnv #5146

merged 1 commit into from
Nov 13, 2024

Conversation

Delapouite
Copy link
Contributor

Hi

A grep across the whole codebase return now other impacted files.

@Delapouite Delapouite requested a review from a team as a code owner November 13, 2024 09:23
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 13, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

pichlermarc
pichlermarc approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc added this pull request to the merge queue Nov 13, 2024
Merged via the queue into open-telemetry:main with commit 699b919 Nov 13, 2024
20 of 21 checks passed
@Delapouite Delapouite deleted the fix/sdk-node-typo branch November 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
pkg:sdk-node Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Delapouite @pichlermarc