-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(sdk-trace-node): support xray propagator (#4602)" #4727
Revert "feat(sdk-trace-node): support xray propagator (#4602)" #4727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof. Does this mean that the @opentelemetry/propagator-aws-xray
pacakge should move back to the contrib repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking for posterity, since I found myself looking for it and others may as well. We had suggested as a follow-up to reconsider the spec guidelines for xray and it was rejected. The getPropagators option sounds like the best move forward anyway.
Yes, that'd be the next step. We can transfer it back to the contrib repo, and we'd have to do the same to The proposed approach above comes a bit closer to what I think we should do in the future (full separation of env var configuration from core SDK packages ( |
…#4602)" (open-telemetry#4727) * Revert "feat(sdk-trace-node): support xray propagator (open-telemetry#4602)" This reverts commit 75d88f7. * chore: sync package-lock.json
This reverts commit 75d88f7.
Which problem is this PR solving?
According to the specification, we MUST NOT maintain the aws and aws-lambda propagators as part of the core repo, therefore we also cannot have it be a dependency of
@opentelemetry/sdk-trace-node
.Therefore this PR reverts #4602 (unreleased)
To replace this feature, I plan to introduce a
getPropagator()
function, which usesOTEL_PROPAGATORS
to build a propagator based on its value, see open-telemetry/opentelemetry-js-contrib#2232