Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resources): ensure BrowserDetector does not think Node.js v21 is a browser #4604

Merged
merged 3 commits into from
Apr 4, 2024
Merged

fix(resources): ensure BrowserDetector does not think Node.js v21 is a browser #4604

merged 3 commits into from
Apr 4, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Apr 3, 2024

Fixes: #4561

@trentm trentm self-assigned this Apr 3, 2024
@trentm trentm requested a review from a team April 3, 2024 22:09
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

Merging #4604 (81a3cd2) into main (b78d443) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4604      +/-   ##
==========================================
+ Coverage   92.83%   92.93%   +0.10%     
==========================================
  Files         329      325       -4     
  Lines        9526     9477      -49     
  Branches     2050     2034      -16     
==========================================
- Hits         8843     8807      -36     
+ Misses        683      670      -13
Files Coverage Δ
...try-resources/src/detectors/BrowserDetectorSync.ts 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

pichlermarc
pichlermarc approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@trentm trentm merged commit c046867 into open-telemetry:main Apr 4, 2024
20 checks passed
@trentm trentm deleted the tm-fix-browser-detect-node-21 branch April 4, 2024 22:24
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@trentm @Zirak
fix(resources): ensure BrowserDetector does not think Node.js v21 is …
468b8a1 
…a browser (open-telemetry#4604)

Fixes: open-telemetry#4561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BrowserDetector detects Node.js v21.0.0 and later as being a browser
2 participants
@trentm @pichlermarc