Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: spelling corrections #4530

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

10xLaCroixDrinker
Copy link
Contributor

Which problem is this PR solving?

Spelling errors

Short description of the changes

Just a few corrections throughout documentation, comments & tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing suite

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@10xLaCroixDrinker 10xLaCroixDrinker requested a review from a team March 7, 2024 17:41
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #4530 (1ce5f2e) into main (7fa2c84) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4530      +/-   ##
==========================================
- Coverage   92.83%   92.82%   -0.02%     
==========================================
  Files         328      328              
  Lines        9481     9481              
  Branches     2031     2031              
==========================================
- Hits         8802     8801       -1     
- Misses        679      680       +1     
Files Coverage Δ
...ckages/opentelemetry-browser-detector/src/types.ts 100.00% <ø> (ø)
...ntelemetry-instrumentation-grpc/src/clientUtils.ts 96.70% <ø> (ø)
...es/opentelemetry-instrumentation-http/src/utils.ts 98.81% <ø> (ø)
...imental/packages/shim-opencensus/src/ShimTracer.ts 79.03% <ø> (ø)
...ontext-async-hooks/src/AsyncHooksContextManager.ts 100.00% <ø> (ø)
...ckages/opentelemetry-core/src/internal/exporter.ts 100.00% <ø> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <ø> (ø)
...elemetry-exporter-zipkin/src/platform/node/util.ts 96.77% <ø> (ø)
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <ø> (ø)
...lemetry-resources/src/detectors/EnvDetectorSync.ts 94.11% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes we had a few good ones in there 😅
Thanks for fixing those 🙂

@pichlermarc pichlermarc merged commit 1b4999f into open-telemetry:main Mar 11, 2024
20 of 21 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the docs/spelling branch March 13, 2024 06:39
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
* docs: spelling corrections

* chore: feedback on spelling changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants