fix(sdk-trace-base): processor onStart called with a span having empty attributes

[satazor]

Which problem is this PR solving?

This PR fixes issue #4188 in which the span processor on start method lacks attributes since they are set after with an accessor method (setAttributes) and not on the constructor itself.

This is a follow up of #4206. I will address any review asap as I'm need of this fix with urgency.

Fixes #4188

Short description of the changes

The PR adds constructor attributes to the span which are optional and if they are added from this layer the spanProcessor.onStart method will have context of attributes whenever it is called, this doest not break compatibility since setAttributes is still a valid public method and also the changes needed on wrappers like the Tracer are done.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• United tested over the build

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[codecov]

Codecov Report

Merging #4277 (a15d748) into main (b0c0ace) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a15d748 differs from pull request most recent head c2a3dda. Consider uploading reports for the commit c2a3dda to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4277      +/-   ##
==========================================
+ Coverage   92.30%   92.31%   +0.01%     
==========================================
  Files         330      330              
  Lines        9419     9421       +2     
  Branches     1995     1996       +1     
==========================================
+ Hits         8694     8697       +3     
+ Misses        725      724       -1     

Files	Coverage Δ
packages/opentelemetry-sdk-trace-base/src/Span.ts	97.45% <100.00%> (+0.04%)	⬆️
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts	98.61% <100.00%> (-0.02%)	⬇️

... and 1 file with indirect coverage changes

[Flarna]

some lint complains + a changelog entry is needed

[satazor]

@Flarna pushed linting fixes and changelog entry

[Flarna]

Please avoid forced pushes after first review has been done. Individual commits ease review. I you need changes from main branch use a merge commit on your branch.
During integration to main all your commits on the branch will be squashed anyway.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ArtAhmetaj (44a3f65)
• ✅ login: satazor / name: André Cruz (190fbf4, 1411439, 8bcd2a9, c2a3dda)

[satazor]

@Flarna sorry, my bad. I'm used to use amend and -f in other projects. Added a new commit with the improvement on the test name.

[pichlermarc]

This looks good; thank you for taking care of this.

[satazor]

@pichlermarc @Flarna ping. Not trying to be intrusive, but this is somewhat urgent since it's requiring a workaround that involves significant overhead. Is something preventing the merge and release of this fix?

[pichlermarc]

@pichlermarc @Flarna ping. Not trying to be intrusive, but this is somewhat urgent since it's requiring a workaround that involves significant overhead. Is something preventing the merge and release of this fix?

I'll merge this in. Keep in mind that this does not mean that it'll be released immediately. I'm trying to shoot for Nov 20