Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guidelines) tiny fix, add comma on docs #4119

Conversation

homekeeper89
Copy link
Contributor

@homekeeper89 homekeeper89 commented Sep 5, 2023

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR just update typo on docs.

Short description of the changes

  • add comma

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@homekeeper89 homekeeper89 requested a review from a team September 5, 2023 01:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: homekeeper89 / name: matthew (ae0d226)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4119 (6fe43b5) into main (6d174e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 6fe43b5 differs from pull request most recent head ae0d226. Consider uploading reports for the commit ae0d226 to get more accurate results

@@           Coverage Diff           @@
##             main    #4119   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         321      321           
  Lines        9282     9282           
  Branches     1973     1973           
=======================================
  Hits         8575     8575           
  Misses        707      707           

@homekeeper89 homekeeper89 changed the title [chore] tiny fix, add comma on docs docs(guidelines) tiny fix, add comma on docs Sep 6, 2023
@homekeeper89
Copy link
Contributor Author

homekeeper89 commented Sep 6, 2023

Thanks! :)

changelog test failed, should i do more?

Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.

@pichlermarc pichlermarc added document Documentation-related Skip Changelog labels Sep 6, 2023
@pichlermarc
Copy link
Member

Thanks! :)

changelog test failed, should i do more?

Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.

No need, applied the Skip Changelog label 🙂

@pichlermarc pichlermarc merged commit 9452607 into open-telemetry:main Sep 6, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants