Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opencensus-shim): implement OpenCensus metric producer #4066

Merged
merged 15 commits into from
Sep 14, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Aug 16, 2023

Which problem is this PR solving?

Part of #3461

Short description of the changes

Implements OpenCensus Metric Producer, which acts as the metrics bridge. See attached bug.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added several new tests
  • Will update example and docs in next PR

Checklist:

@aabmass aabmass changed the title feat(opencensus-shim): implement OpenCensus metric shim feat(opencensus-shim): implement OpenCensus metric producer Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4066 (56f2ecf) into main (937cfaa) will increase coverage by 0.06%.
The diff coverage is 98.87%.

❗ Current head 56f2ecf differs from pull request most recent head f931a38. Consider uploading reports for the commit f931a38 to get more accurate results

@@            Coverage Diff             @@
##             main    #4066      +/-   ##
==========================================
+ Coverage   92.24%   92.30%   +0.06%     
==========================================
  Files         326      328       +2     
  Lines        9299     9385      +86     
  Branches     1971     1993      +22     
==========================================
+ Hits         8578     8663      +85     
- Misses        721      722       +1     
Files Changed Coverage
...al/packages/shim-opencensus/src/trace-transform.ts ø
...l/packages/shim-opencensus/src/metric-transform.ts 98.38%
...es/shim-opencensus/src/OpenCensusMetricProducer.ts 100.00%
...erimental/packages/shim-opencensus/src/ShimSpan.ts 100.00%
...imental/packages/shim-opencensus/src/ShimTracer.ts 100.00%
...mental/packages/shim-opencensus/src/propagation.ts 100.00%

@aabmass aabmass force-pushed the oc-shim-producer branch 2 times, most recently from 35a6582 to 05fcd92 Compare August 16, 2023 03:55
@aabmass aabmass marked this pull request as ready for review August 16, 2023 04:01
@aabmass aabmass requested review from a team August 16, 2023 04:01
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it would be better to add a code document about the difference mentioned above.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I think we need to add one copyright notice then this should be good to merge. 🙂

…ucer.ts

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@aabmass
Copy link
Member Author

aabmass commented Sep 13, 2023

@pichlermarc done

@aabmass
Copy link
Member Author

aabmass commented Sep 14, 2023

Good to merge?

@pichlermarc pichlermarc merged commit 4a4059b into open-telemetry:main Sep 14, 2023
17 checks passed
@aabmass aabmass deleted the oc-shim-producer branch September 15, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants